jenkins-bot has submitted this change and it was merged.
Change subject: VE: Set wgVisualEditorRestbaseURL correctly
......................................................................
VE: Set wgVisualEditorRestbaseURL correctly
wgVisualEditorRestbaseURL is used by the client-side VE code to issue
requests to RESTBase from the browser. don't hard-code it to point to
localhost, but instead use the actual domain served by RESTBase (and
MediaWiki) so that labs instances can profit from it as well. Note that
for this to work in labs-vagrant your instance needs to expose the port
7231 to the outside world.
Change-Id: I6a2d8389e67f343efb70275b65b50423584e2aa3
---
M puppet/modules/role/manifests/restbase.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/puppet/modules/role/manifests/restbase.pp
b/puppet/modules/role/manifests/restbase.pp
index e3457ed..742ae9d 100644
--- a/puppet/modules/role/manifests/restbase.pp
+++ b/puppet/modules/role/manifests/restbase.pp
@@ -23,7 +23,7 @@
mediawiki::settings { 'restbase-visualeditor':
values => {
wgVisualEditorRestbaseURL =>
-
"http://localhost:${::restbase::port}/${::restbase::domain}/v1/page/html/";,
+
"http://${::restbase::domain}:${::restbase::port}/${::restbase::domain}/v1/page/html/";,
},
priority => 6,
}
--
To view, visit https://gerrit.wikimedia.org/r/249758
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a2d8389e67f343efb70275b65b50423584e2aa3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
