Yaron Koren has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250698
Change subject: Fix for generated templates when field is nonempty & has
namespace
......................................................................
Fix for generated templates when field is nonempty & has namespace
Change-Id: I52c922b5487b5c7bf7dc7a815a3c6a021ea795f6
---
M includes/SF_Template.php
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/98/250698/1
diff --git a/includes/SF_Template.php b/includes/SF_Template.php
index 540a203..b3393fe 100644
--- a/includes/SF_Template.php
+++ b/includes/SF_Template.php
@@ -180,9 +180,11 @@
foreach ( $this->mTemplateFields as $i => $field ) {
if ( $field->getFieldName() == '' ) continue;
- $fieldString = '{{{' . $field->getFieldName() . '|}}}';
- if ( !is_null( $field->getNamespace() ) ) {
- $fieldString = $field->getNamespace() . ':' .
$fieldString;
+ $fieldParam = '{{{' . $field->getFieldName() . '|}}}';
+ if ( is_null( $field->getNamespace() ) ) {
+ $fieldString = $fieldParam;
+ } else {
+ $fieldString = $field->getNamespace() . ':' .
$fieldParam;
}
$separator = '';
@@ -215,7 +217,7 @@
if ( $this->mTemplateFormat == 'plain' ||
$this->mTemplateFormat == 'sections' ) {
$tableText .= "\n";
}
- $tableText .= '{{#if:' . $fieldString . '|';
+ $tableText .= '{{#if:' . $fieldParam . '|';
if ( $this->mTemplateFormat == 'standard' ||
$this->mTemplateFormat == 'infobox' ) {
if ( $i > 0 ) {
$tableText .= "\n{{!}}-\n";
--
To view, visit https://gerrit.wikimedia.org/r/250698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52c922b5487b5c7bf7dc7a815a3c6a021ea795f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
