Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250713

Change subject: Unbreak loading of VE in the read page
......................................................................

Unbreak loading of VE in the read page

Change-Id: Ic3e4e65296fa63b3a7d5114366f2859f4ce3f21d
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/13/250713/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 3637b61..672ea79 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -504,8 +504,7 @@
 
                onEditTabClick: function ( e ) {
                        var wikitextModified = $( '#wpTextbox1' ).val() !== 
initialWikitext,
-                               windowManager = new OO.ui.WindowManager(),
-                               switchWindow;
+                               windowManager, switchWindow;
 
                        // Default mouse button is normalised by jQuery to key 
code 1.
                        // Only do our handling if no keys are pressed, mouse 
button is 1
@@ -519,6 +518,7 @@
                                // Prompt if either we're on action=submit (the 
user has previewed) or
                                // the wikitext hash is different to the value 
observed upon page load.
 
+                               windowManager = new OO.ui.WindowManager();
                                $( 'body' ).append( windowManager.$element );
                                switchWindow = new 
ve.ui.MWVESwitchConfirmDialog();
                                windowManager.addWindows( [ switchWindow ] );

-- 
To view, visit https://gerrit.wikimedia.org/r/250713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3e4e65296fa63b3a7d5114366f2859f4ce3f21d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to