Mforns has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250727

Change subject: Optimize queries
......................................................................

Optimize queries

It seems the group by clause is needed to ensure good performance.

Bug: T117220
Change-Id: I663ce6f423e69ffc68cbd945a4ee6494fd75d5f4
---
M ee/distribution_of_response_time.sql
M ee/distribution_of_unread_notifications.sql
M ee/monthly_production_and_consumption_of_notifications.sql
3 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/limn-ee-data 
refs/changes/27/250727/1

diff --git a/ee/distribution_of_response_time.sql 
b/ee/distribution_of_response_time.sql
index 3433c89..44666a5 100644
--- a/ee/distribution_of_response_time.sql
+++ b/ee/distribution_of_response_time.sql
@@ -21,6 +21,7 @@
                        notification_bundle_display_hash
                FROM {wiki_db}.echo_notification
                WHERE notification_bundle_base = 1
+               GROUP BY notification_bundle_display_hash
        ) bundle ON notification.notification_bundle_display_hash = 
bundle.notification_bundle_display_hash AND 
notification.notification_bundle_display_hash != ''
        WHERE notification.notification_timestamp BETWEEN '{from_timestamp}' 
AND '{to_timestamp}'
 ) AS temp;
diff --git a/ee/distribution_of_unread_notifications.sql 
b/ee/distribution_of_unread_notifications.sql
index f168cbc..9ba5c1e 100644
--- a/ee/distribution_of_unread_notifications.sql
+++ b/ee/distribution_of_unread_notifications.sql
@@ -16,6 +16,7 @@
                        notification_bundle_display_hash
                FROM {wiki_db}.echo_notification
                WHERE notification_bundle_base = 1
+               GROUP BY notification_bundle_display_hash
        ) bundle ON notification.notification_bundle_display_hash = 
bundle.notification_bundle_display_hash AND 
notification.notification_bundle_display_hash != ''
        WHERE notification.notification_timestamp BETWEEN '{from_timestamp}' 
AND '{to_timestamp}'
 ) AS temp;
diff --git a/ee/monthly_production_and_consumption_of_notifications.sql 
b/ee/monthly_production_and_consumption_of_notifications.sql
index 9bed52f..b79936d 100644
--- a/ee/monthly_production_and_consumption_of_notifications.sql
+++ b/ee/monthly_production_and_consumption_of_notifications.sql
@@ -25,6 +25,7 @@
                        notification_bundle_display_hash
                FROM {wiki_db}.echo_notification
                WHERE notification_bundle_base = 1
+               GROUP BY notification_bundle_display_hash
        ) bundle ON notification.notification_bundle_display_hash = 
bundle.notification_bundle_display_hash AND 
notification.notification_bundle_display_hash != ''
        WHERE notification.notification_read_timestamp BETWEEN 
'{from_timestamp}' AND '{to_timestamp}'
 ) AS temp;

-- 
To view, visit https://gerrit.wikimedia.org/r/250727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I663ce6f423e69ffc68cbd945a4ee6494fd75d5f4
Gerrit-PatchSet: 1
Gerrit-Project: analytics/limn-ee-data
Gerrit-Branch: master
Gerrit-Owner: Mforns <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to