Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250734
Change subject: Remove dead code
......................................................................
Remove dead code
Dead since 7e9afb6598acde776796639e9ca2102d0ff8860e
Change-Id: Ic0beb0f90446a7dc81c1e915c29800929f42a800
---
M client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
1 file changed, 0 insertions(+), 38 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/34/250734/1
diff --git a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
index f5f3dbc..50d72d7 100644
--- a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
+++ b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php
@@ -50,24 +50,6 @@
}
/**
- * @param EntityUsage[] $usages
- *
- * @return array
- */
- private function getItemIds( array $usages ) {
- $ids = array();
-
- foreach ( $usages as $usage ) {
- $id = $usage->getEntityId();
-
- $key = $id->getSerialization();
- $ids[$key] = $id;
- }
-
- return $ids;
- }
-
- /**
* @param int $pageId
* @param EntityUsage[] $usages
* @param string $touched timestamp
@@ -96,26 +78,6 @@
}
$rows[$key] = $row;
- }
-
- return $rows;
- }
-
- /**
- * @param array[] $rows
- * @param EntityId[] $entityIds
- *
- * @return array[]
- */
- private function removeRowsForEntities( array $rows, array $entityIds )
{
- $idStrings = array_map( function ( EntityId $id ) {
- return $id->getSerialization();
- }, $entityIds );
-
- foreach ( $rows as $key => $row ) {
- if ( in_array( $row['eu_entity_id'], $idStrings ) ) {
- unset( $rows[$key] );
- }
}
return $rows;
--
To view, visit https://gerrit.wikimedia.org/r/250734
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0beb0f90446a7dc81c1e915c29800929f42a800
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
