Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250846

Change subject: Fix "class Foo {" on the same line, add missing @param
......................................................................

Fix "class Foo {" on the same line, add missing @param

Change-Id: I5316ec1adbfcd0a5ea06d5332dc45a4af60c0ae4
---
M includes/InternalSurvey.php
M includes/Survey.php
M includes/SurveyFactory.php
3 files changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys 
refs/changes/46/250846/1

diff --git a/includes/InternalSurvey.php b/includes/InternalSurvey.php
index 43b9619..ebe8eba 100644
--- a/includes/InternalSurvey.php
+++ b/includes/InternalSurvey.php
@@ -2,8 +2,7 @@
 
 namespace QuickSurveys;
 
-class InternalSurvey extends Survey
-{
+class InternalSurvey extends Survey {
        /**
         * @var string The name of the internal survey.
         */
diff --git a/includes/Survey.php b/includes/Survey.php
index c8f39fe..d7ff116 100644
--- a/includes/Survey.php
+++ b/includes/Survey.php
@@ -2,8 +2,7 @@
 
 namespace QuickSurveys;
 
-abstract class Survey
-{
+abstract class Survey {
        /**
         * @var string The friendly name of the survey
         */
diff --git a/includes/SurveyFactory.php b/includes/SurveyFactory.php
index ddac494..63a6a8a 100644
--- a/includes/SurveyFactory.php
+++ b/includes/SurveyFactory.php
@@ -4,8 +4,7 @@
 
 use InvalidArgumentException;
 
-class SurveyFactory
-{
+class SurveyFactory {
        /**
         * Creates an instance of either the InternalSurvey or ExternalSurvey 
class
         * given a specification.
@@ -21,6 +20,7 @@
         *   <li>An external survey must have a privacy policy</li>
         * </ul>
         *
+        * @param array $spec
         * @throws InvalidArgumentException If the configuration is invalid
         * @return Survey
         */

-- 
To view, visit https://gerrit.wikimedia.org/r/250846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5316ec1adbfcd0a5ea06d5332dc45a4af60c0ae4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to