jenkins-bot has submitted this change and it was merged.
Change subject: Add updateRevisionOn() sanity check for existing pages too
......................................................................
Add updateRevisionOn() sanity check for existing pages too
Change-Id: I4f2fc07b0365183efb431a828d40c557b691b18c
---
M includes/page/WikiPage.php
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index ba68e62..2d5cb78 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -1832,7 +1832,10 @@
$revisionId = $revision->insertOn( $dbw );
// Update page_latest and friends to reflect
the new revision
- $this->updateRevisionOn( $dbw, $revision, null,
$oldIsRedirect );
+ if ( !$this->updateRevisionOn( $dbw, $revision,
null, $oldIsRedirect ) ) {
+ $dbw->rollback( __METHOD__ );
+ throw new MWException( "Failed to
update page row to use new revision." );
+ }
Hooks::run( 'NewRevisionFromEditComplete',
array( $this, $revision, $baseRevId,
$user ) );
--
To view, visit https://gerrit.wikimedia.org/r/250876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f2fc07b0365183efb431a828d40c557b691b18c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
