Sbisson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250973
Change subject: Browser tests fixes
......................................................................
Browser tests fixes
* wait for menu item to exist before scroll_into_view
* wait for opt-in/opt-out to have affected the talk page
before moving on to the next step
Change-Id: If30fb5881f9d7e49329573827c4252aa28d60986
---
M tests/browser/features/step_definitions/opt_in_steps.rb
M tests/browser/features/support/pages/abstract_flow_page.rb
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/73/250973/1
diff --git a/tests/browser/features/step_definitions/opt_in_steps.rb
b/tests/browser/features/step_definitions/opt_in_steps.rb
index 74d0f75..99e839c 100644
--- a/tests/browser/features/step_definitions/opt_in_steps.rb
+++ b/tests/browser/features/step_definitions/opt_in_steps.rb
@@ -85,6 +85,7 @@
@topic_title = @data_manager.get 'title'
api.action('flow', submodule: 'new-topic', page: "User_talk:#{@username}",
nttopic: @topic_title, ntcontent: 'created via API')
step 'I disable Flow beta feature'
+ step 'my wikitext talk page is restored'
end
Then(/^my talk page is my old Flow board$/) do
diff --git a/tests/browser/features/support/pages/abstract_flow_page.rb
b/tests/browser/features/support/pages/abstract_flow_page.rb
index 26d63f2..a837198 100644
--- a/tests/browser/features/support/pages/abstract_flow_page.rb
+++ b/tests/browser/features/support/pages/abstract_flow_page.rb
@@ -6,6 +6,7 @@
def select_menu_option(menu, option)
menu.when_present.click
+ wait_until { option.exists? }
option.scroll_into_view
menu.when_present.click
option.when_present.click
--
To view, visit https://gerrit.wikimedia.org/r/250973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If30fb5881f9d7e49329573827c4252aa28d60986
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
