Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250997

Change subject: Maintenance scripts respect 'disabled' config
......................................................................

Maintenance scripts respect 'disabled' config

As soon as we get a config loaded, check for the 'disabled' node
and abort before executing the maintenance task.

Bug: T117451
Change-Id: Id811e03096b3c4eff13fe51063e11a1953422c90
---
M Maintenance/doMaintenance.php
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/97/250997/1

diff --git a/Maintenance/doMaintenance.php b/Maintenance/doMaintenance.php
index 15971eb..a2b3791 100644
--- a/Maintenance/doMaintenance.php
+++ b/Maintenance/doMaintenance.php
@@ -1,4 +1,5 @@
 <?php namespace SmashPig\Maintenance;
+use SmashPig\Core\Context;
 
 if ( !defined( 'RUN_MAINTENANCE_IF_MAIN' ) ) {
        print( "This file must be included after MaintenanceBase.php\n" );
@@ -20,6 +21,14 @@
 if ( $maintenance instanceof MaintenanceBase ) {
        // Perform setup
        $maintenance->setup();
+
+       // Now that we have a config node, check for disablement
+       $config = Context::get()->getConfiguration();
+       if ( $config->nodeExists( 'disabled' ) && $config->val( 'disabled' ) ) {
+               print( 'Processor disabled, will not execute.' );
+               exit( 1 );
+       }
+
        $retval = $maintenance->execute();
 
        if ( $retval ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/250997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id811e03096b3c4eff13fe51063e11a1953422c90
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to