jenkins-bot has submitted this change and it was merged.
Change subject: Fix collapsible header arrows
......................................................................
Fix collapsible header arrows
Collapsible header arrows should point down by default when collapsed.
Renamed confusing variable `isCollapsed` to `wasExpanded`.
Regression introduced in I38c17eacc452942aea8942328c7b26cff0e50d99
Bug: T117578
Change-Id: Idc27d0a5fb55a8c1af064c68403c23ab299fa054
---
M resources/mobile.toggle/toggle.js
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.toggle/toggle.js
b/resources/mobile.toggle/toggle.js
index ccec446..cd8a2dd 100644
--- a/resources/mobile.toggle/toggle.js
+++ b/resources/mobile.toggle/toggle.js
@@ -155,7 +155,7 @@
* @ignore
*/
Toggler.prototype.toggle = function ( $heading ) {
- var isCollapsed = $heading.is( '.open-block' ),
+ var wasExpanded = $heading.is( '.open-block' ),
page = $heading.data( 'page' ),
sectionId = $heading.data( 'section-number' ),
options, indicator;
@@ -163,19 +163,19 @@
$heading.toggleClass( 'open-block' );
$heading.data( 'indicator' ).remove();
- options = isCollapsed ? arrowUpOptions : arrowDownOptions;
+ options = wasExpanded ? arrowDownOptions : arrowUpOptions;
/**
* @event toggled
*/
- this.emit( 'toggled', isCollapsed, sectionId );
+ this.emit( 'toggled', wasExpanded, sectionId );
indicator = new Icon( options ).prependTo( $heading );
$heading.data( 'indicator', indicator );
$heading.next()
.toggleClass( 'open-block' )
.attr( {
- 'aria-pressed': !isCollapsed,
- 'aria-expanded': !isCollapsed
+ 'aria-pressed': !wasExpanded,
+ 'aria-expanded': !wasExpanded
} );
if ( !browser.isWideScreen() ) {
--
To view, visit https://gerrit.wikimedia.org/r/250838
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc27d0a5fb55a8c1af064c68403c23ab299fa054
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jhobs <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhobs <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
