Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251141
Change subject: Hygiene: update Checkstyle ignored annotations
......................................................................
Hygiene: update Checkstyle ignored annotations
Checkstyle enforces private member variables. This patch makes
exceptions to the rule for specific annotations requiring non-public
access.
* Update Butter Knife annotations to be complete.
* Add JUnit @Rule for ActivityTestRule.
Change-Id: I10579f5ee41f12a303c8da6524dcae100729db09
---
M config/checkstyle.xml
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/41/251141/1
diff --git a/config/checkstyle.xml b/config/checkstyle.xml
index 2744504..f64a3d7 100644
--- a/config/checkstyle.xml
+++ b/config/checkstyle.xml
@@ -159,6 +159,17 @@
<module name="VisibilityModifier">
<!-- Butter Knife -->
<property name="ignoreAnnotationCanonicalNames" value="Bind" />
+ <property name="ignoreAnnotationCanonicalNames" value="BindBool" />
+ <property name="ignoreAnnotationCanonicalNames" value="BindColor"
/>
+ <property name="ignoreAnnotationCanonicalNames" value="BindDimen"
/>
+ <property name="ignoreAnnotationCanonicalNames"
value="BindDrawable" />
+ <property name="ignoreAnnotationCanonicalNames" value="BindInt" />
+ <property name="ignoreAnnotationCanonicalNames" value="BindString"
/>
+ <property name="ignoreAnnotationCanonicalNames" value="OnClick" />
+ <property name="ignoreAnnotationCanonicalNames"
value="OnItemSelected" />
+
+ <!-- Testing -->
+ <property name="ignoreAnnotationCanonicalNames" value="Rule" />
</module>
<!-- Miscellaneous other checks. -->
<!-- See http://checkstyle.sf.net/config_misc.html -->
--
To view, visit https://gerrit.wikimedia.org/r/251141
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10579f5ee41f12a303c8da6524dcae100729db09
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
