Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251258
Change subject: Add missing view tests and fix @groups
......................................................................
Add missing view tests and fix @groups
This adds some absolute basic tests just to increase coverage in this
directory.
Change-Id: Ib31d471e59eef8caef12717189a06523232e3916
---
M view/tests/phpunit/ClaimHtmlGeneratorTest.php
A view/tests/phpunit/Module/TemplateModuleTest.php
A view/tests/phpunit/Template/TemplateFactoryTest.php
M view/tests/phpunit/Template/TemplateRegistryTest.php
M view/tests/phpunit/Template/TemplateTest.php
5 files changed, 101 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/58/251258/1
diff --git a/view/tests/phpunit/ClaimHtmlGeneratorTest.php
b/view/tests/phpunit/ClaimHtmlGeneratorTest.php
index 52f532c..5c25f46 100644
--- a/view/tests/phpunit/ClaimHtmlGeneratorTest.php
+++ b/view/tests/phpunit/ClaimHtmlGeneratorTest.php
@@ -45,10 +45,11 @@
}
/**
+ * @dataProvider getHtmlForClaimProvider
+ *
* @uses Wikibase\View\Template\Template
* @uses Wikibase\View\Template\TemplateFactory
* @uses Wikibase\View\Template\TemplateRegistry
- * @dataProvider getHtmlForClaimProvider
*/
public function testGetHtmlForClaim(
SnakHtmlGenerator $snakHtmlGenerator,
diff --git a/view/tests/phpunit/Module/TemplateModuleTest.php
b/view/tests/phpunit/Module/TemplateModuleTest.php
new file mode 100644
index 0000000..1cbf694
--- /dev/null
+++ b/view/tests/phpunit/Module/TemplateModuleTest.php
@@ -0,0 +1,37 @@
+<?php
+
+namespace Wikibase\View\Template\Test;
+
+use PHPUnit_Framework_TestCase;
+use Wikibase\View\Module\TemplateModule;
+
+/**
+ * @covers Wikibase\View\Module\TemplateModule
+ *
+ * @group Wikibase
+ * @group WikibaseView
+ *
+ * @licence GNU GPL v2+
+ * @author Thiemo Mättig
+ */
+class TemplateModuleTest extends PHPUnit_Framework_TestCase {
+
+ public function testGetScript() {
+ $context = $this->getMockBuilder( 'ResourceLoaderContext' )
+ ->disableOriginalConstructor()
+ ->getMock();
+ $context->expects( $this->any() )
+ ->method( 'getLanguage' )
+ ->will( $this->returnValue( 'en' ) );
+
+ $instance = new TemplateModule();
+ $script = $instance->getScript( $context );
+ $this->assertInternalType( 'string', $script );
+ }
+
+ public function testSupportsURLLoading() {
+ $instance = new TemplateModule();
+ $this->assertFalse( $instance->supportsURLLoading() );
+ }
+
+}
diff --git a/view/tests/phpunit/Template/TemplateFactoryTest.php
b/view/tests/phpunit/Template/TemplateFactoryTest.php
new file mode 100644
index 0000000..4e674ed
--- /dev/null
+++ b/view/tests/phpunit/Template/TemplateFactoryTest.php
@@ -0,0 +1,50 @@
+<?php
+
+namespace Wikibase\View\Template\Test;
+
+use PHPUnit_Framework_TestCase;
+use Wikibase\View\Template\TemplateFactory;
+use Wikibase\View\Template\TemplateRegistry;
+
+/**
+ * @covers Wikibase\View\Template\TemplateFactory
+ *
+ * @group Wikibase
+ * @group WikibaseView
+ *
+ * @licence GNU GPL v2+
+ * @author Thiemo Mättig
+ */
+class TemplateFactoryTest extends PHPUnit_Framework_TestCase {
+
+ private function newInstance() {
+ return new TemplateFactory( new TemplateRegistry( array(
+ 'empty' => '',
+ ) ) );
+ }
+
+ public function testGetDefaultInstance() {
+ $instance = TemplateFactory::getDefaultInstance();
+ $this->assertInstanceOf(
'Wikibase\View\Template\TemplateFactory', $instance );
+ }
+
+ public function testGetTemplates() {
+ $instance = $this->newInstance();
+ $templates = $instance->getTemplates();
+ $this->assertInternalType( 'array', $templates );
+ $this->assertContainsOnly( 'string', $templates );
+ }
+
+ public function testGet() {
+ $instance = $this->newInstance();
+ $template = $instance->get( 'empty', array() );
+ $this->assertInstanceOf( 'Wikibase\View\Template\Template',
$template );
+ }
+
+ public function testRender() {
+ $instance = $this->newInstance();
+ $rendered = $instance->render( 'empty' );
+ $this->assertSame( '', $rendered );
+ }
+
+}
diff --git a/view/tests/phpunit/Template/TemplateRegistryTest.php
b/view/tests/phpunit/Template/TemplateRegistryTest.php
index 808a8cc..1ba265a 100644
--- a/view/tests/phpunit/Template/TemplateRegistryTest.php
+++ b/view/tests/phpunit/Template/TemplateRegistryTest.php
@@ -8,7 +8,7 @@
* @covers Wikibase\View\Template\TemplateRegistry
*
* @group Wikibase
- * @group WikibaseLib
+ * @group WikibaseView
*
* @licence GNU GPL v2+
* @author H. Snater <[email protected]>
diff --git a/view/tests/phpunit/Template/TemplateTest.php
b/view/tests/phpunit/Template/TemplateTest.php
index 19c6264..caf8065 100644
--- a/view/tests/phpunit/Template/TemplateTest.php
+++ b/view/tests/phpunit/Template/TemplateTest.php
@@ -2,23 +2,30 @@
namespace Wikibase\View\Template\Test;
+use PHPUnit_Framework_TestCase;
use Wikibase\View\Template\Template;
use Wikibase\View\Template\TemplateRegistry;
/**
* @covers Wikibase\View\Template\Template
+ *
* @uses Wikibase\View\Template\TemplateRegistry
*
* @group Wikibase
- * @group WikibaseLib
+ * @group WikibaseView
*
* @licence GNU GPL v2+
* @author H. Snater <[email protected]>
*/
-class TemplateTest extends \MediaWikiTestCase {
+class TemplateTest extends PHPUnit_Framework_TestCase {
+
+ public function testRender() {
+ $instance = new Template( new TemplateRegistry( array( 'empty'
=> '' ) ), 'empty' );
+ $rendered = $instance->render();
+ $this->assertSame( '', $rendered );
+ }
/**
- * @group WikibaseLib
* @dataProvider providerText
*/
public function testText( $html ) {
@@ -26,7 +33,7 @@
$registry->addTemplate( 'tmpl1', $html );
$template = new Template( $registry, 'tmpl1', array( 'param' )
);
- $this->assertHTMLEquals( $template->text(), '<div>param</div>'
);
+ $this->assertSame( '<div>param</div>', $template->text() );
}
public function providerText() {
--
To view, visit https://gerrit.wikimedia.org/r/251258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib31d471e59eef8caef12717189a06523232e3916
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
