Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251260
Change subject: Decrease binding in EntityParserOutputDataUpdater
......................................................................
Decrease binding in EntityParserOutputDataUpdater
And make the method names more clearly match their responsibility
Change-Id: I7b68c4f6a861b5cf2eca9893aa061261654d71b0
---
M repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
1 file changed, 8 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/60/251260/1
diff --git a/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
b/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
index 1b68c94..007b656 100644
--- a/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
+++ b/repo/includes/ParserOutput/EntityParserOutputDataUpdater.php
@@ -6,6 +6,8 @@
use ParserOutput;
use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\Item;
+use Wikibase\DataModel\SiteLinkList;
+use Wikibase\DataModel\Statement\StatementList;
use Wikibase\DataModel\Statement\StatementListProvider;
/**
@@ -61,43 +63,34 @@
$this->dataUpdaters = $dataUpdaters;
}
- /**
- * @param EntityDocument $entity
- */
public function processEntity( EntityDocument $entity ) {
if ( $entity instanceof StatementListProvider ) {
- $this->processStatementListProvider( $entity );
+ $this->processStatementList( $entity->getStatements() );
}
if ( $entity instanceof Item ) {
- $this->processItem( $entity );
+ $this->processSiteLinks( $entity->getSiteLinkList() );
}
}
- /**
- * @param StatementListProvider $entity
- */
- private function processStatementListProvider( StatementListProvider
$entity ) {
+ private function processStatementList( StatementList $statements ) {
if ( empty( $this->statementDataUpdaters ) ) {
return;
}
- foreach ( $entity->getStatements() as $statement ) {
+ foreach ( $statements as $statement ) {
foreach ( $this->statementDataUpdaters as $updater ) {
$updater->processStatement( $statement );
}
}
}
- /**
- * @param Item $item
- */
- private function processItem( Item $item ) {
+ private function processSiteLinks( SiteLinkList $siteLinks ) {
if ( empty( $this->siteLinkDataUpdaters ) ) {
return;
}
- foreach ( $item->getSiteLinkList() as $siteLink ) {
+ foreach ( $siteLinks as $siteLink ) {
foreach ( $this->siteLinkDataUpdaters as $updater ) {
$updater->processSiteLink( $siteLink );
}
--
To view, visit https://gerrit.wikimedia.org/r/251260
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b68c4f6a861b5cf2eca9893aa061261654d71b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
