OliverKeyes has submitted this change and it was merged. Change subject: Resolve rare bug ......................................................................
Resolve rare bug Sometimes lubridate::month/week(dataset[, 1]) yields: Error in as.POSIXlt.default(x, tz = tz(x)) : do not know how to convert 'x' to class “POSIXlt” This is meant to address that. Change-Id: Iff01c7289191e4594a571232783ea90f70f1d440 --- M DESCRIPTION M NEWS.md M R/smoothing.R 3 files changed, 10 insertions(+), 6 deletions(-) Approvals: OliverKeyes: Verified; Looks good to me, approved diff --git a/DESCRIPTION b/DESCRIPTION index 2d6e95e..5292f5a 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: polloi Type: Package Title: Common Functionality for Wikimedia Dashboards -Version: 0.0.4 -Date: 2015-09-30 +Version: 0.0.5 +Date: 2015-11-04 Author: Oliver Keyes [aut, cre], Mikhail Popov [aut] Maintainer: Oliver Keyes <[email protected]> Description: This package (which I can say because BDR is nowhere in sight) contains common functionality diff --git a/NEWS.md b/NEWS.md index c6d9914..da1a980 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +polloi 0.0.5 +============= +- Added subsetting by date range + polloi 0.0.4 ============= - Added a change log diff --git a/R/smoothing.R b/R/smoothing.R index 30194d6..c0b3c74 100644 --- a/R/smoothing.R +++ b/R/smoothing.R @@ -40,13 +40,13 @@ # whatsoever, and so the original dataset is returned. switch(smooth_level, week = { - dataset$filter_1 <- lubridate::week(dataset[, 1]) - dataset$filter_2 <- lubridate::year(dataset[, 1]) + dataset$filter_1 <- lubridate::week(dataset[[1]]) + dataset$filter_2 <- lubridate::year(dataset[[1]]) name_append <- ifelse(rename, " (Weekly average)", "") }, month = { - dataset$filter_1 <- lubridate::month(dataset[, 1]) - dataset$filter_2 <- lubridate::year(dataset[, 1]) + dataset$filter_1 <- lubridate::month(dataset[[1]]) + dataset$filter_2 <- lubridate::year(dataset[[1]]) name_append <- ifelse(rename, " (Monthly average)", "") }, { -- To view, visit https://gerrit.wikimedia.org/r/251170 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff01c7289191e4594a571232783ea90f70f1d440 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/discovery/polloi Gerrit-Branch: master Gerrit-Owner: Bearloga <[email protected]> Gerrit-Reviewer: OliverKeyes <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
