OliverKeyes has submitted this change and it was merged.
Change subject: Add 'all data' as a time frame option that was missing
......................................................................
Add 'all data' as a time frame option that was missing
Change-Id: Ibcd007fbb0dac246d4e6e947044a459b25d0bdcb
---
M ui.R
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
OliverKeyes: Verified; Looks good to me, approved
diff --git a/ui.R b/ui.R
index 6071b7d..b770c1e 100644
--- a/ui.R
+++ b/ui.R
@@ -15,8 +15,9 @@
# Standardized selectors for time frame
timeframe_select <- function(input_id, label = "Time Frame") {
return(selectInput(inputId = input_id, label = label, selectize = TRUE,
selected = "global",
- choices = c("Use Global Setting" = "global", "Last 7
days" = "week",
- "Last 30 days" = "month", "Last 90 days" =
"quarter", "Custom" = "custom")))
+ choices = c("Use Global Setting" = "global", "All
available data" = "all",
+ "Last 7 days" = "week", "Last 30 days" =
"month",
+ "Last 90 days" = "quarter", "Custom" =
"custom")))
}
timeframe_daterange <- function(select_input_id, label = "Custom Date Range") {
return(conditionalPanel(paste0("input.", select_input_id," == 'custom'"),
--
To view, visit https://gerrit.wikimedia.org/r/251425
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcd007fbb0dac246d4e6e947044a459b25d0bdcb
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/rainbow
Gerrit-Branch: master
Gerrit-Owner: Bearloga <[email protected]>
Gerrit-Reviewer: OliverKeyes <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
