jenkins-bot has submitted this change and it was merged. Change subject: Fix modification of section edit link ......................................................................
Fix modification of section edit link Return the (modified) $result instead of true, otherwise nothing gets changed actually. Change-Id: I9cfaf98dd053acd85afbcfaf83e8a1cf93629d8d Signed-off-by: Tiziano Müller <[email protected]> --- M DiscussionThreading.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Florianschmidtwelzow: Looks good to me, approved jenkins-bot: Verified diff --git a/DiscussionThreading.php b/DiscussionThreading.php index 61b80ab..3299155 100644 --- a/DiscussionThreading.php +++ b/DiscussionThreading.php @@ -63,7 +63,7 @@ return ( true ); } -function efDoDiscussionLink ( $callobj , $nt , $section , $hint='' , $result , $lang = false ) +function efDoDiscussionLink ( $callobj , $nt , $section , $hint='' , &$result ) { global $wgSectionThreadingOn; if($wgSectionThreadingOn && $nt->isTalkPage() ) { @@ -80,7 +80,7 @@ $curl = '<span class="mw-editsection-bracket">[</span>' . $curl . '<span class="mw-editsection-bracket">]</span>'; $result = $spanOpen.$nurl.$strippedResults.$curl.$spanClose; } - return ( true ); + return true; } -- To view, visit https://gerrit.wikimedia.org/r/153392 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cfaf98dd053acd85afbcfaf83e8a1cf93629d8d Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/DiscussionThreading Gerrit-Branch: master Gerrit-Owner: Dev-zero <[email protected]> Gerrit-Reviewer: Dev-zero <[email protected]> Gerrit-Reviewer: Florianschmidtwelzow <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
