Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/251688

Change subject: Break long lines and cleanup some RefreshLinksJob checks
......................................................................

Break long lines and cleanup some RefreshLinksJob checks

Change-Id: I02c007a2c2032610551d71ce1b21e03db5c011db
---
M includes/jobqueue/jobs/RefreshLinksJob.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/251688/1

diff --git a/includes/jobqueue/jobs/RefreshLinksJob.php 
b/includes/jobqueue/jobs/RefreshLinksJob.php
index 25c3ba4..5f1a1a6 100644
--- a/includes/jobqueue/jobs/RefreshLinksJob.php
+++ b/includes/jobqueue/jobs/RefreshLinksJob.php
@@ -216,10 +216,10 @@
                        $title, null, !empty( 
$this->params['useRecursiveLinksUpdate'] ), $parserOutput );
                foreach ( $updates as $key => $update ) {
                        if ( $update instanceof LinksUpdate ) {
-                               if ( isset( $this->params['triggeredRecursive'] 
) ) {
+                               if ( !empty( 
$this->params['triggeredRecursive'] ) ) {
                                        $update->setTriggeredRecursive();
                                }
-                               if ( isset( $this->params['triggeringUser'] ) 
&& $this->params['triggeringUser'] ) {
+                               if ( !empty( $this->params['triggeringUser'] ) 
) {
                                        $userInfo = 
$this->params['triggeringUser'];
                                        if ( $userInfo['userId'] ) {
                                                $user = User::newFromId( 
$userInfo['userId'] );
@@ -229,7 +229,7 @@
                                        }
                                        $update->setTriggeringUser( $user );
                                }
-                               if ( isset( 
$this->params['triggeringRevisionId'] ) && 
$this->params['triggeringRevisionId'] ) {
+                               if ( !empty( 
$this->params['triggeringRevisionId'] ) ) {
                                        $revision = Revision::newFromId( 
$this->params['triggeringRevisionId'] );
                                        if ( $revision === null ) {
                                                $revision = Revision::newFromId(

-- 
To view, visit https://gerrit.wikimedia.org/r/251688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02c007a2c2032610551d71ce1b21e03db5c011db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to