Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251937
Change subject: Small bug fixes
......................................................................
Small bug fixes
Change-Id: I2dacf12b3884c6fdc3e222f11e7b696c55003925
---
M gui/wikibase/codemirror/addon/hint/wikibase-sparql-hint.js
M gui/wikibase/codemirror/addon/tooltip/WikibaseRDFTooltip.js
2 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf
refs/changes/37/251937/1
diff --git a/gui/wikibase/codemirror/addon/hint/wikibase-sparql-hint.js
b/gui/wikibase/codemirror/addon/hint/wikibase-sparql-hint.js
index d16e7fe..8946465 100755
--- a/gui/wikibase/codemirror/addon/hint/wikibase-sparql-hint.js
+++ b/gui/wikibase/codemirror/addon/hint/wikibase-sparql-hint.js
@@ -39,11 +39,6 @@
}
};
- CodeMirror.hint.sparql.async = true;
- CodeMirror.defaults.hintOptions = {};
- CodeMirror.defaults.hintOptions.closeCharacters = /[]/;
- CodeMirror.defaults.hintOptions.completeSingle = false;
-
function getSPARQLHints( term ){
var list = [];
@@ -60,7 +55,7 @@
var variables = [];
$.each(text.split(' '), function( key, word ){
- if( word.indexOf('?') === 0){
+ if( word.match(/^\?[a-zA-Z0-9]+$/)){
variables.push(word);
}
});
diff --git a/gui/wikibase/codemirror/addon/tooltip/WikibaseRDFTooltip.js
b/gui/wikibase/codemirror/addon/tooltip/WikibaseRDFTooltip.js
index 254bc09..f729ad8 100644
--- a/gui/wikibase/codemirror/addon/tooltip/WikibaseRDFTooltip.js
+++ b/gui/wikibase/codemirror/addon/tooltip/WikibaseRDFTooltip.js
@@ -50,7 +50,6 @@
var posX = e.clientX, posY = (e.clientY +
$(window).scrollTop());
var token =
this.editor.getTokenAt(this.editor.coordsChar({left: posX, top: posY})).string;
- console.log(token);
if(!token.match(/.+\:(Q|P)[0-9]*/)){
return;
--
To view, visit https://gerrit.wikimedia.org/r/251937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dacf12b3884c6fdc3e222f11e7b696c55003925
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
