AndyRussG has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252118
Change subject: impressionDiet: don't restart cycle when restartCycleDelay is 0
......................................................................
impressionDiet: don't restart cycle when restartCycleDelay is 0
Change-Id: Icaa5918b957d7ed0457a0a5b308222bd85c5f63e
---
M resources/subscribing/ext.centralNotice.impressionDiet.js
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/18/252118/1
diff --git a/resources/subscribing/ext.centralNotice.impressionDiet.js
b/resources/subscribing/ext.centralNotice.impressionDiet.js
index 49bd3d7..42c3c42 100644
--- a/resources/subscribing/ext.centralNotice.impressionDiet.js
+++ b/resources/subscribing/ext.centralNotice.impressionDiet.js
@@ -92,13 +92,22 @@
counts.waitSeenCount += 1;
counts.seenCount += 1;
- if ( counts.waitSeenCount >= mixinParams.maximumSeen ) {
- // We just completed a cycle. Wait to restart.
+ // For restartCycleDelay, 0 is a magic number that
means, never
+ // restart
+ if ( ( mixinParams.restartCycleDelay !== 0) &&
+ ( counts.waitSeenCount >=
mixinParams.maximumSeen ) ) {
+
+ // We just completed a cycle. Wait to restart.
counts.waitCount = 0;
counts.waitSeenCount = 0;
counts.waitUntil = new Date().getTime() +
( mixinParams.restartCycleDelay * 1000
);
}
+
+ } else if ( ( mixinParams.restartCycleDelay === 0 ) &&
+ ( pastDate && !waitForHideImps && !waitForShowImps ) ) {
+
+ hide = 'waitnorestart';
}
if ( hide === null ) {
--
To view, visit https://gerrit.wikimedia.org/r/252118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaa5918b957d7ed0457a0a5b308222bd85c5f63e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <andrew.green...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
