DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252124
Change subject: Watch for hashchance on the demo
......................................................................
Watch for hashchance on the demo
Change-Id: Iff3284eaf202a92bc5db9bb00c9e31bf9008ca28
---
M demos/ve/ve.demo.init.js
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/24/252124/1
diff --git a/demos/ve/ve.demo.init.js b/demos/ve/ve.demo.init.js
index 4dd4e00..cd30e08 100644
--- a/demos/ve/ve.demo.init.js
+++ b/demos/ve/ve.demo.init.js
@@ -9,6 +9,7 @@
var $toolbar = $( '.ve-demo-targetToolbar' ),
$editor = $( '.ve-demo-editor' ),
target = new ve.demo.target(),
+ hashChanging = false,
currentLang = $.i18n().locale,
currentDir = target.$element.css( 'direction' ) || 'ltr',
@@ -116,6 +117,9 @@
$editor.append( target.$element );
function updateHash() {
+ if ( hashChanging ) {
+ return false;
+ }
var i, pages = [];
if ( history.replaceState ) {
for ( i = 0; i < ve.demo.surfaceContainers.length; i++
) {
@@ -154,5 +158,15 @@
createSurfacesFromHash( location.hash );
- // TODO: hashchange handler?
+ $( window ).on( 'hashchange', function ( e ) {
+ if ( hashChanging ) {
+ return;
+ }
+ hashChanging = true;
+ ve.demo.surfaceContainers.slice().forEach( function ( container
) {
+ container.destroy();
+ } );
+ createSurfacesFromHash( location.hash );
+ hashChanging = false;
+ } );
} );
--
To view, visit https://gerrit.wikimedia.org/r/252124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff3284eaf202a92bc5db9bb00c9e31bf9008ca28
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
