jenkins-bot has submitted this change and it was merged.
Change subject: Watch for hashchange on the demo
......................................................................
Watch for hashchange on the demo
Change-Id: Iff3284eaf202a92bc5db9bb00c9e31bf9008ca28
---
M demos/ve/ve.demo.init.js
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/ve/ve.demo.init.js b/demos/ve/ve.demo.init.js
index 4dd4e00..b24962e 100644
--- a/demos/ve/ve.demo.init.js
+++ b/demos/ve/ve.demo.init.js
@@ -9,6 +9,7 @@
var $toolbar = $( '.ve-demo-targetToolbar' ),
$editor = $( '.ve-demo-editor' ),
target = new ve.demo.target(),
+ hashChanging = false,
currentLang = $.i18n().locale,
currentDir = target.$element.css( 'direction' ) || 'ltr',
@@ -117,6 +118,9 @@
function updateHash() {
var i, pages = [];
+ if ( hashChanging ) {
+ return false;
+ }
if ( history.replaceState ) {
for ( i = 0; i < ve.demo.surfaceContainers.length; i++
) {
pages.push( ve.demo.surfaceContainers[ i
].pageMenu.getSelectedItem().getData() );
@@ -154,5 +158,15 @@
createSurfacesFromHash( location.hash );
- // TODO: hashchange handler?
+ $( window ).on( 'hashchange', function () {
+ if ( hashChanging ) {
+ return;
+ }
+ hashChanging = true;
+ ve.demo.surfaceContainers.slice().forEach( function ( container
) {
+ container.destroy();
+ } );
+ createSurfacesFromHash( location.hash );
+ hashChanging = false;
+ } );
} );
--
To view, visit https://gerrit.wikimedia.org/r/252124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff3284eaf202a92bc5db9bb00c9e31bf9008ca28
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
