20after4 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252408
Change subject: Fix MWOAuthRequest::fromRequest logging
......................................................................
Fix MWOAuthRequest::fromRequest logging
Logging was converted to use the logger interface in
I92ffac553b6552b26cb6f531c2d10d7bca777900, but this was done not taking
into account the fact that function is static.
Bug: T118372
Change-Id: Ib9b800d3d7ddd095856c5deaf88be82d64db0fb8
---
M backend/MWOAuthRequest.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth
refs/changes/08/252408/1
diff --git a/backend/MWOAuthRequest.php b/backend/MWOAuthRequest.php
index 9861ca3..b69611e 100644
--- a/backend/MWOAuthRequest.php
+++ b/backend/MWOAuthRequest.php
@@ -37,6 +37,7 @@
public static function fromRequest( \WebRequest $request ) {
$httpMethod = strtoupper( $request->getMethod() );
$httpUrl = $request->getFullRequestURL();
+ $logger = LoggerFactory::getInstance( 'OAuth' );
// Find request headers
$requestHeaders = MWOAuthUtils::getHeaders();
@@ -54,7 +55,7 @@
) === 0
) {
$postData = OAuthUtil::parse_parameters(
$request->getRawPostString() );
- $this->logger->debug( __METHOD__ . ': Post String = ' .
implode( ',', $postData ) );
+ $logger->debug( __METHOD__ . ': Post String = ' .
implode( ',', $postData ) );
$parameters = array_merge( $parameters, $postData );
}
@@ -68,7 +69,7 @@
);
$parameters = array_merge($parameters,
$headerParameters);
}
- $this->logger->debug( __METHOD__ . ": parameters:\n" . print_r(
$parameters, true) );
+ $logger->debug( __METHOD__ . ": parameters:\n" . print_r(
$parameters, true) );
return new self( $httpMethod, $httpUrl, $parameters,
$request->getIP() );
}
--
To view, visit https://gerrit.wikimedia.org/r/252408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9b800d3d7ddd095856c5deaf88be82d64db0fb8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: wmf/1.27.0-wmf.6
Gerrit-Owner: 20after4 <mmod...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
