Filippo Giunchedi has uploaded a new change for review. https://gerrit.wikimedia.org/r/252418
Change subject: fix stdout/stderr shell redirection syntax - take #2 ...................................................................... fix stdout/stderr shell redirection syntax - take #2 followup from Idbc339cafe0 Change-Id: I4e6add0a18eab686b1370fd404cbc1aed3648c83 --- M modules/elasticsearch/manifests/log/hot_threads.pp M modules/mediawiki/manifests/maintenance/translationnotifications.pp 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/18/252418/1 diff --git a/modules/elasticsearch/manifests/log/hot_threads.pp b/modules/elasticsearch/manifests/log/hot_threads.pp index 3594226..d201502 100644 --- a/modules/elasticsearch/manifests/log/hot_threads.pp +++ b/modules/elasticsearch/manifests/log/hot_threads.pp @@ -12,7 +12,7 @@ } cron { 'elasticsearch-hot-threads-log': - command => "python ${script} 2>&1 >> ${log}", + command => "python ${script} >> ${log} 2>&1", #So the destination directory exists require => Package['elasticsearch'], user => 'elasticsearch', diff --git a/modules/mediawiki/manifests/maintenance/translationnotifications.pp b/modules/mediawiki/manifests/maintenance/translationnotifications.pp index d25ff0d..73739f4 100644 --- a/modules/mediawiki/manifests/maintenance/translationnotifications.pp +++ b/modules/mediawiki/manifests/maintenance/translationnotifications.pp @@ -6,7 +6,8 @@ cron { 'translationnotifications-metawiki': ensure => $ensure, user => $::mediawiki::users::web, - command => '/usr/local/bin/mwscript extensions/TranslationNotifications/scripts/DigestEmailer.php --wiki metawiki 2>&1 >> /var/log/translationnotifications/digests.log', + command => '/usr/local/bin/mwscript + extensions/TranslationNotifications/scripts/DigestEmailer.php --wiki metawiki >> /var/log/translationnotifications/digests.log 2>&1', weekday => 1, # Monday hour => 10, minute => 0, @@ -15,7 +16,7 @@ cron { 'translationnotifications-mediawikiwiki': ensure => $ensure, user => $::mediawiki::users::web, - command => '/usr/local/bin/mwscript extensions/TranslationNotifications/scripts/DigestEmailer.php --wiki mediawikiwiki 2>&1 >> /var/log/translationnotifications/digests.log', + command => '/usr/local/bin/mwscript extensions/TranslationNotifications/scripts/DigestEmailer.php --wiki mediawikiwiki >> /var/log/translationnotifications/digests.log 2>&1', weekday => 1, # Monday hour => 10, minute => 5, -- To view, visit https://gerrit.wikimedia.org/r/252418 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4e6add0a18eab686b1370fd404cbc1aed3648c83 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits