JanZerebecki has uploaded a new change for review. https://gerrit.wikimedia.org/r/252508
Change subject: Temporarily skip a test that fails on HHVM. ...................................................................... Temporarily skip a test that fails on HHVM. HHVM has a bug in json decode https://github.com/facebook/hhvm/issues/5813 . Skip the test until there is a fix upstream. Bug: T103346 Change-Id: I7e44d98c29ba9b9f5443665fc046382f696193c9 --- M tests/engines/LuaCommon/TextLibraryTest.php 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto refs/changes/08/252508/1 diff --git a/tests/engines/LuaCommon/TextLibraryTest.php b/tests/engines/LuaCommon/TextLibraryTest.php index 3a31280..fffcd9a 100644 --- a/tests/engines/LuaCommon/TextLibraryTest.php +++ b/tests/engines/LuaCommon/TextLibraryTest.php @@ -3,6 +3,15 @@ class Scribunto_LuaTextLibraryTests extends Scribunto_LuaEngineTestBase { protected static $moduleName = 'TextLibraryTests'; + public function __construct( $name = null, array $data = array(), $dataName = '', $engineName = null ) { + parent::__construct( $name, $data, $dataName, $engineName); + if ( defined('HHVM_VERSION') ) { + // HHVM bug https://github.com/facebook/hhvm/issues/5813$ + $this->skipTests['json decode, invalid values (trailing comma)'] = + 'json decode bug in HHVM'; + } + } + protected function setUp() { parent::setUp(); -- To view, visit https://gerrit.wikimedia.org/r/252508 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e44d98c29ba9b9f5443665fc046382f696193c9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Scribunto Gerrit-Branch: master Gerrit-Owner: JanZerebecki <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
