Mholloway has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252692
Change subject: Fix pages reached via internal links not being recognized as
saved
......................................................................
Fix pages reached via internal links not being recognized as saved
Removes underscores from page title strings before generating a
PageTitle object from an internal link, in order to maintain
formatting consistency in the text field; this ensures that the title
strings will be recognized when checked against the list of saved
pages in the database when populating the save/refresh action bar
menu item.
Bug: T108885
Change-Id: I90d04b07f67f3df21460172c89343829e0d32ba1
---
M app/src/main/java/org/wikipedia/Site.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/92/252692/1
diff --git a/app/src/main/java/org/wikipedia/Site.java
b/app/src/main/java/org/wikipedia/Site.java
index baa2434..1025f6e 100644
--- a/app/src/main/java/org/wikipedia/Site.java
+++ b/app/src/main/java/org/wikipedia/Site.java
@@ -119,7 +119,7 @@
public PageTitle titleForInternalLink(String internalLink) {
// FIXME: Handle language variant links properly
// Strip the /wiki/ from the href
- return new PageTitle(internalLink.replaceFirst("/wiki/", ""), this);
+ return new PageTitle(internalLink.replaceFirst("/wiki/",
"").replace("_", " "), this);
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/252692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90d04b07f67f3df21460172c89343829e0d32ba1
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
