jenkins-bot has submitted this change and it was merged.
Change subject: UploadWizardCampaign: Fix PHP warning when checking buttons
......................................................................
UploadWizardCampaign: Fix PHP warning when checking buttons
Notice: Undefined index: display in
.../extensions/UploadWizard/includes/UploadWizardCampaign.php on line 478
isset() will suppress the boring notices.
Change-Id: Iac59b02cf15e2cbd4fa875fe3508b838f55260aa
---
M includes/UploadWizardCampaign.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
MarkTraceur: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/UploadWizardCampaign.php
b/includes/UploadWizardCampaign.php
index 638e118..e330b18 100755
--- a/includes/UploadWizardCampaign.php
+++ b/includes/UploadWizardCampaign.php
@@ -475,8 +475,8 @@
$customizableButtons = array( 'homeButton', 'beginButton' );
foreach ( $customizableButtons as $button ) {
- if ( array_key_exists( $button,
$this->parsedConfig['display'] ) &&
-
$this->parsedConfig['display'][$button]['target'] === 'useObjref'
+ if ( isset(
$this->parsedConfig['display'][$button]['target'] ) &&
+
$this->parsedConfig['display'][$button]['target'] === 'useObjref'
) {
$validUrl =
$this->getButtonHrefByObjectReference( $objRef );
if ( $validUrl ) {
--
To view, visit https://gerrit.wikimedia.org/r/252679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac59b02cf15e2cbd4fa875fe3508b838f55260aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Kai Nissen (WMDE) <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
