Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252955
Change subject: swift: use double quote in graphite query
......................................................................
swift: use double quote in graphite query
looks like icinga will strip single quotes when executing the command
Bug: T118398
Change-Id: I6423e48cf471cc63bef3b73700296212e1a8951b
---
M modules/swift/manifests/monitoring/graphite_alerts.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/55/252955/1
diff --git a/modules/swift/manifests/monitoring/graphite_alerts.pp
b/modules/swift/manifests/monitoring/graphite_alerts.pp
index 763c356..3de7715 100644
--- a/modules/swift/manifests/monitoring/graphite_alerts.pp
+++ b/modules/swift/manifests/monitoring/graphite_alerts.pp
@@ -23,7 +23,7 @@
monitoring::graphite_threshold { "mediawiki_${cluster}_media_uploads":
description => "mediawiki originals uploads (hourly) for
${cluster}",
- metric =>
"summarize(nonNegativeDerivative(keepLastValue(swift.${cluster}.containers.mw-media.originals.objects)),
'1h')",
+ metric =>
"summarize(nonNegativeDerivative(keepLastValue(swift.${cluster}.containers.mw-media.originals.objects)),
\"1h\")",
from => '5h',
warning => 2000,
critical => 3000,
--
To view, visit https://gerrit.wikimedia.org/r/252955
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6423e48cf471cc63bef3b73700296212e1a8951b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
