Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/253283

Change subject: Fix Non-static method AuthorSubmission::createFromScratch() 
should not be called statically
......................................................................

Fix Non-static method AuthorSubmission::createFromScratch() should not be 
called statically

Found by
https://integration.wikimedia.org/ci/job/mwext-testextension-zend/14676/console

Change-Id: I16dbf3d26e779f87a3055583fc8fa9ce7f88006e
---
M model/AuthorSubmission.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConventionExtension 
refs/changes/83/253283/1

diff --git a/model/AuthorSubmission.php b/model/AuthorSubmission.php
index c4b7732..d142160 100644
--- a/model/AuthorSubmission.php
+++ b/model/AuthorSubmission.php
@@ -92,7 +92,7 @@
         * @return AuthorSubmission, if successful contains the submission 
page_id
         *
         */
-       public function createFromScratch( $aid, $properties )
+       public static function createFromScratch( $aid, $properties )
        {
                if ( !$properties || ( !isset( $properties['title'] ) || 
!$properties['title'] ) )
                {

-- 
To view, visit https://gerrit.wikimedia.org/r/253283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I16dbf3d26e779f87a3055583fc8fa9ce7f88006e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConventionExtension
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to