Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/253295

Change subject: redis: Add upstart support to redis::instance
......................................................................

redis: Add upstart support to redis::instance

Bug: T118704
Change-Id: I10eed026a9a2bd99a14e575159d065541d75a8d0
---
M modules/redis/manifests/instance.pp
A modules/redis/templates/initscripts/redis-instance.upstart.erb
2 files changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/253295/1

diff --git a/modules/redis/manifests/instance.pp 
b/modules/redis/manifests/instance.pp
index cf62bc3..e02dfb8 100644
--- a/modules/redis/manifests/instance.pp
+++ b/modules/redis/manifests/instance.pp
@@ -34,7 +34,6 @@
 
     validate_ensure($ensure)
     validate_hash($settings)
-    validate_re($::initsystem, 'systemd')
 
     include ::redis
 
@@ -81,6 +80,7 @@
         ensure        => $ensure,
         template_name => 'redis-instance',
         systemd       => true,
+        upstart       => true,
         subscribe     => File["/etc/redis/${instance_name}.conf"],
     }
 }
diff --git a/modules/redis/templates/initscripts/redis-instance.upstart.erb 
b/modules/redis/templates/initscripts/redis-instance.upstart.erb
new file mode 100644
index 0000000..d1b0c71
--- /dev/null
+++ b/modules/redis/templates/initscripts/redis-instance.upstart.erb
@@ -0,0 +1,16 @@
+# This file is managed by Puppet
+description "Advanced key-value store"
+
+start on started network-services
+
+setuid redis
+setgid redis
+
+exec /usr/bin/redis-server /etc/redis/<%= @instance_name %>.conf
+
+# We expect daemonize=yes
+expect fork
+
+respawn
+
+# vim: set ft=upstart:

-- 
To view, visit https://gerrit.wikimedia.org/r/253295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10eed026a9a2bd99a14e575159d065541d75a8d0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to