jenkins-bot has submitted this change and it was merged.
Change subject: Improve Special:CreateNewsletter
......................................................................
Improve Special:CreateNewsletter
* Add introductory message
* Remove legend as it's not necessary here because all the form
elements are related to each other.
* Change title to "Create newsletter" as it's more accurate and consistent
with other special page names.
Change-Id: I2c6669a7a6ab5d86648616ff7d543a24347fd60b
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialNewsletterCreate.php
3 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index ff83756..e18ec3b 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -7,7 +7,8 @@
]
},
"newsletter-extension-desc": "Enables users to publish and subscribe to
newsletters",
- "newslettercreate": "Create newsletters",
+ "newslettercreate": "Create newsletter",
+ "newslettercreate-text": "This page allows you to create a new
newsletter. You will be added as a publisher and subscribed to the newsletter
on its creation.",
"newslettermanage": "Manage newsletters",
"newsletter-name": "Name of newsletter",
"newsletter-desc": "Description",
@@ -18,7 +19,6 @@
"newsletter-required-fields-error": "Required fields are empty",
"newsletter-exist-error": "A newsletter with the same name already
exists. Try again with another name",
"newsletter-addpublisherform-addpublisher-section": "Add publishers",
- "newsletter-create-section": "Create newsletter",
"newsletter-create-submit": "Create newsletter",
"newsletter-create-confirmation": "A new newsletter has been
successfully created. You can manage newsletters through
[[Special:ManageNewsletter]].",
"newsletter-create-mainpage-error": "Invalid newsletter main page
entered. Please try again.",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 518915a..f2528fd 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -11,7 +11,7 @@
]
},
"newsletter-extension-desc": "Description of the extension",
- "newslettercreate": "Name of special page which creates newsletters as
seen in URLs and links",
+ "newslettercreate": "Name of [[Special:CreateNewsletter]]. This is used
as the header on this page and shown in links to the page.",
"newslettermanage": "Name of special page which announces issues as
seen in URLs and links",
"newsletter-name": "Label of the field which takes the name of
newsletter as input in [[Special:ManageNewsletter]] and
[[Special:CreateNewsletter]]",
"newsletter-desc": "Label of the field which takes a short description
of newsletter as input in
[[Special:CreateNewsletter]]\n{{Identical|Description}}",
@@ -22,7 +22,6 @@
"newsletter-required-fields-error": "Error message to be displayed when
required fields are empty in [[Special:ManageNewsletter]]",
"newsletter-exist-error": "Error message to be displayed in
[[Special:CreateNewsletter]] when trying to create a newsletter with same name
as an existing newsletter",
"newsletter-addpublisherform-addpublisher-section": "Header of section
in [[Special:ManageNewsletter]] which adds publishers",
- "newsletter-create-section": "Section header of
[[Special:CreateNewsletter]]",
"newsletter-create-submit": "Label of submit button on
[[Special:CreateNewsletter]]",
"newsletter-create-confirmation": "Confirmation message displayed after
creation of a newsletter",
"newsletter-create-mainpage-error": "Error message shown on
[[Special:CreateNewsletter]] if the page entered on main page field does not
exist.",
diff --git a/includes/specials/SpecialNewsletterCreate.php
b/includes/specials/SpecialNewsletterCreate.php
index ddbce76..8994823 100644
--- a/includes/specials/SpecialNewsletterCreate.php
+++ b/includes/specials/SpecialNewsletterCreate.php
@@ -24,7 +24,6 @@
*/
protected function alterForm( HTMLForm $form ) {
$form->setSubmitTextMsg( 'newsletter-create-submit' );
- $form->setWrapperLegendMsg( 'newsletter-create-section' );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/252710
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c6669a7a6ab5d86648616ff7d543a24347fd60b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
Gerrit-Reviewer: 01tonythomas <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Tinaj1234 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
