jenkins-bot has submitted this change and it was merged.
Change subject: Convert hex value to decimal. Don't just cast to int.
......................................................................
Convert hex value to decimal. Don't just cast to int.
Tiffinfo usually returns something like "EXIFIFDOffset: 0x1ab38078".
This code tried to do (int)"0x1ab38078", which is equal to 0,
not 447971448 as is needed.
As a result, PagedTiffHandler was counting exif segments as new pages
where it should not have been.
Bug: T87318
Change-Id: I5d4860f093f9710f76c7c9e7af50f60e85fe6715
---
M PagedTiffHandler.image.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/PagedTiffHandler.image.php b/PagedTiffHandler.image.php
index 332d2b6..689837f 100644
--- a/PagedTiffHandler.image.php
+++ b/PagedTiffHandler.image.php
@@ -290,6 +290,10 @@
} elseif ( preg_match('/.*IFDOffset/', $key) ) {
# ignore extra IFDs, see
<http://www.awaresystems.be/imaging/tiff/tifftags/exififd.html>
# Note: we assume that we will always
see the reference before the actual IFD, so we know which IFDs to ignore
+ // Offset is usually in hex
+ if ( preg_match( '/^0x[0-9A-Fa-f]+$/',
$value ) ) {
+ $value = hexdec( substr(
$value, 2 ) );
+ }
$offset = (int)$value;
$ignoreIFDs[$offset] = true;
}
--
To view, visit https://gerrit.wikimedia.org/r/253280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d4860f093f9710f76c7c9e7af50f60e85fe6715
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/PagedTiffHandler
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
