Spage has submitted this change and it was merged. Change subject: Rename test file, improve tests slightly. ......................................................................
Rename test file, improve tests slightly. phpunit wants files named *Test.php (singular). Add another test, but the test suite still fails on the first significant test with "This test printed output:" I'll submit a separate patch fixing the new "Use of wfMsg was deprecated in MediaWiki 1.21." warning Change-Id: I47657aa485e43ed5794153627e7a7ffc0e010ff5 --- M tests/ExperimentsTest.hooks.php M tests/phpunit/Makefile R tests/phpunit/api/ApiAccountCreationTest.php 3 files changed, 29 insertions(+), 19 deletions(-) Approvals: Ori.livneh: Looks good to me, approved Spage: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38817 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47657aa485e43ed5794153627e7a7ffc0e010ff5 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
