Robert Vogel has submitted this change and it was merged.
Change subject: Fixed deletion of skin
......................................................................
Fixed deletion of skin
When deleting an active flexiskin, the active skin was not reset to
standard. The reason is a wrong variable name ($iId instead of $sId).
Fixed now.
Change-Id: Id2c02b34e8752507df15829d1201c12e25cf232e
---
M Flexiskin/includes/FlexiskinApi.class.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Flexiskin/includes/FlexiskinApi.class.php
b/Flexiskin/includes/FlexiskinApi.class.php
index a137a4b..5681667 100644
--- a/Flexiskin/includes/FlexiskinApi.class.php
+++ b/Flexiskin/includes/FlexiskinApi.class.php
@@ -182,8 +182,8 @@
return FormatJson::encode( array( 'success' => false,
'msg' => wfMessage( 'bs-flexiskin-api-error-missing-param', 'id' )->plain() ) );
}
- $oStatus = BsFileSystemHelper::deleteFolder( "flexiskin" . DS .
$iId );
- if ( BsConfig::get( "MW::Flexiskin::Active" ) == $iId ) {
+ $oStatus = BsFileSystemHelper::deleteFolder( "flexiskin" . DS .
$sId );
+ if ( BsConfig::get( "MW::Flexiskin::Active" ) == $sId ) {
BsConfig::set( "MW::Flexiskin::Active", "" );
BsConfig::saveSettings();
}
--
To view, visit https://gerrit.wikimedia.org/r/253888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2c02b34e8752507df15829d1201c12e25cf232e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
