Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/254389
Change subject: Remove unreachable return
......................................................................
Remove unreachable return
Which is also an undefined variable
Change-Id: I01c5a0b5d5fb8d353bf1addd706caccd9590d370
---
M src/PSquare.php
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/RunningStat refs/changes/89/254389/1
diff --git a/src/PSquare.php b/src/PSquare.php
index aae7e70..0a392af 100644
--- a/src/PSquare.php
+++ b/src/PSquare.php
@@ -192,7 +192,6 @@
} else {
return $this->heights[floor( $i )];
}
- return $result;
}
return $this->heights[2];
--
To view, visit https://gerrit.wikimedia.org/r/254389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01c5a0b5d5fb8d353bf1addd706caccd9590d370
Gerrit-PatchSet: 1
Gerrit-Project: RunningStat
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits