[MediaWiki-commits] [Gerrit] Start using StatementGrouper from DataModelServices - change (mediawiki...Wikibase)

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/254394

Change subject: Start using StatementGrouper from DataModelServices
......................................................................

Start using StatementGrouper from DataModelServices

This requires a new release 3.2.0 of DataModelServices.

Bug: T118951
Change-Id: I0498a1d451613e11fffe14a98d2a0adf7315d4a6
---
M view/src/ItemView.php
M view/src/PropertyView.php
2 files changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/94/254394/1

diff --git a/view/src/ItemView.php b/view/src/ItemView.php
index 7ddefaf..0078386 100644
--- a/view/src/ItemView.php
+++ b/view/src/ItemView.php
@@ -5,6 +5,7 @@
 use InvalidArgumentException;
 use Language;
 use Wikibase\DataModel\Entity\Item;
+use Wikibase\DataModel\Services\Statement\Grouper\NullStatementGrouper;
 use Wikibase\EntityRevision;
 use Wikibase\View\Template\TemplateFactory;
 
@@ -71,10 +72,10 @@
                }
 
                $html = parent::getMainHtml( $entityRevision );
-               // TODO: Group statements into sections.
-               $html .= $this->statementSectionsView->getHtml( array(
-                       'statements' => $item->getStatements(),
-               ) );
+               // TODO: Group statements into actual sections, including an 
identifiers section.
+               $grouper = new NullStatementGrouper();
+               $statementLists = $grouper->groupStatements( 
$item->getStatements() );
+               $html .= $this->statementSectionsView->getHtml( $statementLists 
);
 
                return $html;
        }
diff --git a/view/src/PropertyView.php b/view/src/PropertyView.php
index 065ee70..57bdce0 100644
--- a/view/src/PropertyView.php
+++ b/view/src/PropertyView.php
@@ -7,6 +7,7 @@
 use InvalidArgumentException;
 use Language;
 use Wikibase\DataModel\Entity\Property;
+use Wikibase\DataModel\Services\Statement\Grouper\NullStatementGrouper;
 use Wikibase\EntityRevision;
 use Wikibase\View\Template\TemplateFactory;
 
@@ -65,10 +66,10 @@
                $html = parent::getMainHtml( $entityRevision );
                $html .= $this->getHtmlForDataType( $this->getDataType( 
$property ) );
 
-               // TODO: Group statements into sections.
-               $html .= $this->statementSectionsView->getHtml( array(
-                       'statements' => $property->getStatements(),
-               ) );
+               // TODO: Group statements into actual sections, including an 
identifiers section.
+               $grouper = new NullStatementGrouper();
+               $statementLists = $grouper->groupStatements( 
$property->getStatements() );
+               $html .= $this->statementSectionsView->getHtml( $statementLists 
);
 
                $footer = wfMessage( 'wikibase-property-footer' );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/254394
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0498a1d451613e11fffe14a98d2a0adf7315d4a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits