Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/254427
Change subject: RuboCop: regenerated TODO file
......................................................................
RuboCop: regenerated TODO file
Some problems have been fixed or introduced since the last RuboCop
fixes and RuboCop job is failing. This commit fixes the job.
Change-Id: I643af96295ccd55928e1c8e190662e493e616622
---
M .rubocop_todo.yml
1 file changed, 15 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/27/254427/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 392497e..2023e77 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2015-11-12 18:39:32 +0100 using RuboCop version 0.35.1.
+# on 2015-11-20 17:44:21 +0100 using RuboCop version 0.35.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
@@ -53,7 +53,7 @@
- 'modules/wmflib/lib/hiera/backend/nuyaml_backend.rb'
- 'modules/wmflib/lib/puppet/parser/functions/validate_array_re.rb'
-# Offense count: 182
+# Offense count: 187
# Configuration parameters: AllowURI, URISchemes.
Metrics/LineLength:
Max: 158
@@ -117,13 +117,14 @@
- 'modules/base/lib/facter/physicalcorecount.rb'
- 'modules/puppetmaster/lib/puppet/reports/logstash.rb'
-# Offense count: 2
+# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles,
AllowInnerBackticks.
Style/CommandLiteral:
Exclude:
- 'modules/apt/lib/facter/apt.rb'
- 'modules/ganeti/lib/facter/ganeti.rb'
+ - 'modules/gridengine/lib/puppet/provider/gridengine_resource/parsed.rb'
# Offense count: 1
# Cop supports --auto-correct.
@@ -190,25 +191,19 @@
- 'utils/expanderb.rb'
- 'utils/hiera_lookup'
-# Offense count: 1
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
- Exclude:
- - 'utils/hiera_lookup'
-
-# Offense count: 366
+# Offense count: 375
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles,
UseHashRocketsWithSymbolValues.
Style/HashSyntax:
Enabled: false
-# Offense count: 23
+# Offense count: 22
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
Enabled: false
-# Offense count: 266
+# Offense count: 276
# Cop supports --auto-correct.
# Configuration parameters: Width.
Style/IndentationWidth:
@@ -245,7 +240,7 @@
Exclude:
- 'modules/ganeti/lib/facter/ganeti.rb'
-# Offense count: 19
+# Offense count: 20
# Cop supports --auto-correct.
Style/NegatedIf:
Enabled: false
@@ -284,7 +279,7 @@
Exclude:
- 'modules/wmflib/lib/puppet/parser/functions/ipresolve.rb'
-# Offense count: 8
+# Offense count: 10
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
@@ -293,6 +288,7 @@
- 'modules/base/lib/facter/initsystem.rb'
- 'modules/base/lib/facter/lldp.rb'
- 'modules/ganeti/lib/facter/ganeti.rb'
+ - 'modules/gridengine/lib/puppet/provider/gridengine_resource/parsed.rb'
# Offense count: 2
# Cop supports --auto-correct.
@@ -354,11 +350,12 @@
- 'modules/wmflib/lib/puppet/parser/functions/php_ini.rb'
- 'modules/wmflib/lib/puppet/parser/functions/require_package.rb'
-# Offense count: 1
+# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: AllowAsExpressionSeparator.
Style/Semicolon:
Exclude:
+ - 'modules/gridengine/lib/puppet/provider/gridengine_resource/parsed.rb'
- 'modules/wmflib/lib/puppet/parser/functions/ordered_yaml.rb'
# Offense count: 23
@@ -395,7 +392,7 @@
- 'modules/wmflib/lib/hiera/backend/proxy_backend.rb'
- 'modules/wmflib/spec/hiera/role_backend_spec.rb'
-# Offense count: 38
+# Offense count: 39
# Cop supports --auto-correct.
Style/SpaceInsideBrackets:
Enabled: false
@@ -420,13 +417,13 @@
- 'modules/puppetmaster/files/puppetstoredconfigclean.rb'
- 'utils/expanderb.rb'
-# Offense count: 153
+# Offense count: 188
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
Style/StringLiterals:
Enabled: false
-# Offense count: 116
+# Offense count: 117
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
Style/TrailingComma:
--
To view, visit https://gerrit.wikimedia.org/r/254427
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I643af96295ccd55928e1c8e190662e493e616622
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Zfilipin <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits