Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255338
Change subject: Suggestions: For a fresh favorite list, set display name and
type
......................................................................
Suggestions: For a fresh favorite list, set display name and type
Not setting these values was cauing the list appearing below the page.
Change-Id: I65213cd2c301d5c1a3907517617933df21c7f11e
---
M extension.json
M modules/dashboard/ext.cx.suggestionlist.js
2 files changed, 4 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/38/255338/1
diff --git a/extension.json b/extension.json
index 5257c2b..9484d55 100644
--- a/extension.json
+++ b/extension.json
@@ -833,6 +833,7 @@
"cx-suggestionlist-empty-desc",
"cx-suggestionlist-empty-title",
"cx-suggestionlist-expand",
+ "cx-suggestionlist-favorite",
"cx-suggestionlist-featured",
"cx-suggestionlist-refresh",
"cx-suggestionlist-empty-desc-recommend-link-text",
diff --git a/modules/dashboard/ext.cx.suggestionlist.js
b/modules/dashboard/ext.cx.suggestionlist.js
index 37bb10c..fb522a6 100644
--- a/modules/dashboard/ext.cx.suggestionlist.js
+++ b/modules/dashboard/ext.cx.suggestionlist.js
@@ -579,8 +579,10 @@
// We need to construct a dummy list
for now to help the UI rendering.
favoriteListId =
'cx-suggestionlist-favorite';
self.lists[ favoriteListId ] = {
+ displayName: mw.msg(
'cx-suggestionlist-favorite' ),
name: favoriteListId,
- suggestions: []
+ suggestions: [],
+ type: listTypes.TYPE_FAVORITE
};
}
suggestion.listId = favoriteListId;
--
To view, visit https://gerrit.wikimedia.org/r/255338
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65213cd2c301d5c1a3907517617933df21c7f11e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
