jenkins-bot has submitted this change and it was merged. Change subject: Fixed Style/RegexpLiteral RuboCop offense ......................................................................
Fixed Style/RegexpLiteral RuboCop offense Change-Id: I48129105ca804176e5cfafe75a28dccd39c4c78e See: https://github.com/bbatsov/ruby-style-guide#percent-r Bug: T117985 --- M .rubocop.yml D .rubocop_todo.yml M tests/browser/features/support/pages/page_triage_page.rb 3 files changed, 1 insertion(+), 17 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml index 3c8a650..84567a5 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,3 @@ -inherit_from: .rubocop_todo.yml - AllCops: StyleGuideCopsOnly: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index 56c3c7f..0000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,14 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2015-11-25 15:37:03 +0100 using RuboCop version 0.35.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. -Style/RegexpLiteral: - Exclude: - - 'tests/browser/features/support/pages/page_triage_page.rb' diff --git a/tests/browser/features/support/pages/page_triage_page.rb b/tests/browser/features/support/pages/page_triage_page.rb index 3804fd3..e3d3927 100644 --- a/tests/browser/features/support/pages/page_triage_page.rb +++ b/tests/browser/features/support/pages/page_triage_page.rb @@ -17,7 +17,7 @@ radio_button(:blocked, id: 'mwe-pt-filter-blocked') radio_button(:bots, id: 'mwe-pt-filter-bot-edits') checkbox(:deletion, id: 'mwe-pt-filter-nominated-for-deletion') - a(:learn_more, href: /Wikipedia:Page_Curation\/Help/, text: 'Learn more') + a(:learn_more, href: %r{Wikipedia:Page_Curation/Help}, text: 'Learn more') a(:leave_feedback, href: /Wikipedia_talk:Page_Curation/, text: 'Leave feedback') select(:namespace, id: 'mwe-pt-filter-namespace') radio_button(:new_editors, id: 'mwe-pt-filter-non-autoconfirmed') -- To view, visit https://gerrit.wikimedia.org/r/255389 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48129105ca804176e5cfafe75a28dccd39c4c78e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
