Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255423
Change subject: Add grunt-jscs
......................................................................
Add grunt-jscs
Change-Id: Ifc164690132a85808ad5301754e276b63915ddd6
---
A .jscsrc
M Gruntfile.js
M package.json
3 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeReview
refs/changes/23/255423/1
diff --git a/.jscsrc b/.jscsrc
new file mode 100644
index 0000000..b1232a3
--- /dev/null
+++ b/.jscsrc
@@ -0,0 +1,7 @@
+{
+ "preset": "wikimedia",
+ "validateQuoteMarks": null,
+ "requireVarDeclFirst": null,
+ "requireMultipleVarDecl": null,
+ "requireCamelCaseOrUpperCaseIdentifiers": null
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index 9725424..4a46bae 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -11,6 +11,7 @@
grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-jscs' );
grunt.initConfig( {
jshint: {
@@ -22,6 +23,9 @@
'!node_modules/**'
]
},
+ jscs: {
+ src: '<%= jshint.all %>'
+ },
banana: conf.MessagesDirs,
jsonlint: {
all: [
@@ -31,6 +35,6 @@
}
} );
- grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana' ]
);
grunt.registerTask( 'default', 'test' );
};
diff --git a/package.json b/package.json
index 94fd835..f7d6059 100644
--- a/package.json
+++ b/package.json
@@ -11,6 +11,7 @@
"grunt-cli": "0.1.13",
"grunt-contrib-jshint": "0.11.3",
"grunt-banana-checker": "0.4.0",
- "grunt-jsonlint": "1.0.6"
+ "grunt-jsonlint": "1.0.6",
+ "grunt-jscs": "2.3.0"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/255423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc164690132a85808ad5301754e276b63915ddd6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
