jenkins-bot has submitted this change and it was merged.
Change subject: isBlockedTrigger should use meta+ for macs, not cmd+
......................................................................
isBlockedTrigger should use meta+ for macs, not cmd+
Change-Id: I75ccbb4c9ed80beefd48866431d316fc09065dff
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
Objections:
Esanders: There's a problem with this change, please improve
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 5d6ec68..d8b4f30 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1082,7 +1082,7 @@
ve.ce.Surface.prototype.isBlockedTrigger = function ( trigger ) {
var platformKey = ve.getSystemPlatform() === 'mac' ? 'mac' : 'pc',
blocked = {
- mac: [ 'cmd+b', 'cmd+i', 'cmd+u', 'cmd+z', 'cmd+y',
'cmd+shift+z', 'tab', 'shift+tab' ],
+ mac: [ 'meta+b', 'meta+i', 'meta+u', 'meta+z',
'meta+y', 'meta+shift+z', 'tab', 'shift+tab' ],
pc: [ 'ctrl+b', 'ctrl+i', 'ctrl+u', 'ctrl+z', 'ctrl+y',
'ctrl+shift+z', 'tab', 'shift+tab' ]
};
--
To view, visit https://gerrit.wikimedia.org/r/255474
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75ccbb4c9ed80beefd48866431d316fc09065dff
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
