Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255940
Change subject: WPB show no banner when images disabled
......................................................................
WPB show no banner when images disabled
Turns off pagebanner when using skin minerva with images disabled.
Bug: T107368
Change-Id: If4aa5110ad51258ea4a147e46b531e719fe49363
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/40/255940/1
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index f8cbb25..45834d3 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -73,6 +73,11 @@
* @return bool
*/
public static function addBanner( OutputPage $out, Skin $skin ) {
+ // if images are disabled on Minerva skin, then do nothing
+ if ( $skin->getSkinName() === 'minerva' &&
+ (bool)$out->getRequest()->getCookie(
'disableImages' ) === true ) {
+ return true;
+ }
$config = WikidataPageBannerFunctions::getWPBConfig();
$title = $out->getTitle();
$isDiff = $out->getRequest()->getVal( 'diff' );
--
To view, visit https://gerrit.wikimedia.org/r/255940
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4aa5110ad51258ea4a147e46b531e719fe49363
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
