jenkins-bot has submitted this change and it was merged.
Change subject: Use $.map from jQuery
......................................................................
Use $.map from jQuery
This requires jQuery >= 1.6. This is included in MediaWiki >= 1.18.
This change drops support for MediaWiki 1.17.
Change-Id: I12f3f3e22d9bc47a0a2d9a9d201af4e44012e0a2
---
M modules/jquery.codeEditor.js
1 file changed, 1 insertion(+), 13 deletions(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index 1e2054d..4a4ebba 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -652,19 +652,7 @@
* us fall back to the originals when we turn off.
*/
saveAndExtend = function ( base, extended ) {
- var map;
-
- // $.map doesn't handle objects in jQuery < 1.6; need
this for compat with MW 1.17
- map = function ( obj, callback ) {
- var key;
-
- for ( key in extended ) {
- if ( obj.hasOwnProperty( key ) ) {
- callback( obj[ key ], key );
- }
- }
- };
- map( extended, function ( func, name ) {
+ $.map( extended, function ( func, name ) {
var orig;
if ( name in base ) {
orig = base[ name ];
--
To view, visit https://gerrit.wikimedia.org/r/255944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12f3f3e22d9bc47a0a2d9a9d201af4e44012e0a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
