jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] Remove unnecessary variable definitions ......................................................................
[IMPROV] Remove unnecessary variable definitions Defining a function locale variable directly before a `return` statement which is not using that variable is unnecessary. Change-Id: Idf623fad2498a0395b8b40a6bc2b78bba15fc412 --- M scripts/checkimages.py 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/checkimages.py b/scripts/checkimages.py index 0e752e5..762f6d6 100755 --- a/scripts/checkimages.py +++ b/scripts/checkimages.py @@ -1532,7 +1532,6 @@ # Here begins the check block. if brackets and license_found: # It works also without this... but i want only to be sure ^^ - brackets = False return True elif delete: pywikibot.output(u"%s is not a file!" % self.imageName) @@ -1542,7 +1541,6 @@ notification = din % self.imageName head = dih self.report(canctext, self.imageName, notification, head) - delete = False return True elif self.imageCheckText in nothing: pywikibot.output( -- To view, visit https://gerrit.wikimedia.org/r/256411 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf623fad2498a0395b8b40a6bc2b78bba15fc412 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <commodorefabia...@gmx.de> Gerrit-Reviewer: John Vandenberg <jay...@gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits