jenkins-bot has submitted this change and it was merged.

Change subject: Fix column widths in NewsletterTablePager
......................................................................


Fix column widths in NewsletterTablePager

Make this look a bit less awkward.

Change-Id: I1da3277315b0dc7492aa3ede74bde65404118e9d
---
M includes/specials/pagers/NewsletterTablePager.php
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/pagers/NewsletterTablePager.php 
b/includes/specials/pagers/NewsletterTablePager.php
index 400132c..a51ec59 100644
--- a/includes/specials/pagers/NewsletterTablePager.php
+++ b/includes/specials/pagers/NewsletterTablePager.php
@@ -123,12 +123,19 @@
         */
        public function getCellAttrs( $field, $value ) {
                $ret = parent::getCellAttrs( $field, $value );
+               // @todo use CSS, not inline HTML
                switch( $field ) {
+                       case 'nl_name':
+                               $ret['width'] = '20%';
+                               break;
                        case 'nl_desc':
-                               $ret['width'] = '50%';
+                               $ret['width'] = '40%';
+                               break;
+                       case 'subscriber_count':
+                               $ret['width'] = '5%';
                                break;
                        case 'action':
-                               $ret['width'] = '25%';
+                               $ret['width'] = '20%';
                                break;
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/256400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1da3277315b0dc7492aa3ede74bde65404118e9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to