jenkins-bot has submitted this change and it was merged. Change subject: SpecialNewsletter: use $this->getPageTitle() instead of SpecialPage::getTitleFor('Newsletter') ......................................................................
SpecialNewsletter: use $this->getPageTitle() instead of SpecialPage::getTitleFor('Newsletter') Change-Id: Iefefafe88ff26a6b24a86d7cf85d5b55ddccbae7 --- M includes/specials/SpecialNewsletter.php 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialNewsletter.php b/includes/specials/SpecialNewsletter.php index f6aae6f..5ce9bea 100644 --- a/includes/specials/SpecialNewsletter.php +++ b/includes/specials/SpecialNewsletter.php @@ -186,7 +186,7 @@ 'label' => $this->msg( 'newsletter-delete-button' )->escaped(), 'flags' => array( 'destructive' ), 'icon' => 'remove', - 'href' => SpecialPage::getTitleFor( 'Newsletter', $id . '/' . self::NEWSLETTER_DELETE )->getFullURL() + 'href' => $this->getPageTitle( $id . '/' . self::NEWSLETTER_DELETE )->getFullURL() ) ); } @@ -208,7 +208,7 @@ 'label' => $this->msg( 'newsletter-announce-button' )->escaped(), 'flags' => array( 'progressive' ), 'icon' => 'comment', - 'href' => SpecialPage::getTitleFor( 'Newsletter', $id . '/' . self::NEWSLETTER_ANNOUNCE )->getFullURL() + 'href' => $this->getPageTitle( $id . '/' . self::NEWSLETTER_ANNOUNCE )->getFullURL() ) ); } @@ -218,7 +218,7 @@ array( 'label' => $this->msg( 'newsletter-unsubscribe-button' )->escaped(), 'flags' => array( 'primary', 'destructive' ), - 'href' => SpecialPage::getTitleFor( 'Newsletter', $id . '/' . self::NEWSLETTER_UNSUBSCRIBE )->getFullURL() + 'href' => $this->getPageTitle( $id . '/' . self::NEWSLETTER_UNSUBSCRIBE )->getFullURL() ) ); } else { @@ -226,7 +226,7 @@ array( 'label' => $this->msg( 'newsletter-subscribe-button' )->escaped(), 'flags' => array( 'primary', 'constructive' ), - 'href' => SpecialPage::getTitleFor( 'Newsletter', $id . '/' . self::NEWSLETTER_SUBSCRIBE )->getFullURL() + 'href' => $this->getPageTitle( $id . '/' . self::NEWSLETTER_SUBSCRIBE )->getFullURL() ) ); } @@ -317,7 +317,7 @@ $form->addHeaderText( $txt ); $form->suppressDefaultSubmit(); $form->show(); - $this->getOutput()->addReturnTo( SpecialPage::getTitleFor( 'Newsletter', $this->newsletter->getId() ) ); + $this->getOutput()->addReturnTo( $this->getPageTitle( $this->newsletter->getId() ) ); } /** @@ -523,7 +523,7 @@ if ( !$form->show() ) { // After submission, no point in showing showing the return to link if the newsletter was just deleted - $out->addReturnTo( SpecialPage::getTitleFor( 'Newsletter', $this->newsletter->getId() ) ); + $out->addReturnTo( $this->getPageTitle( $this->newsletter->getId() ) ); } } -- To view, visit https://gerrit.wikimedia.org/r/256401 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefefafe88ff26a6b24a86d7cf85d5b55ddccbae7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Newsletter Gerrit-Branch: master Gerrit-Owner: Glaisher <glaisher.w...@gmail.com> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits