[MediaWiki-commits] [Gerrit] eventlogging, varnish: fix last 2 quoting warnings - change (operations/puppet)

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/256472

Change subject: eventlogging, varnish: fix last 2 quoting warnings
......................................................................

eventlogging, varnish: fix last 2 quoting warnings

These are the last 2 lint warnings of the type
"double quoted string containing no variable"
across the entire repo (except submodule cassandra).

After fixing these we can re-enable that particular lint check.

Bug:T93645
Change-Id: Ic834d12574d5d5eb04c9701c83c8250451f7d693
---
M modules/eventlogging/manifests/monitoring/graphite.pp
M modules/varnish/manifests/instance.pp
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/72/256472/1

diff --git a/modules/eventlogging/manifests/monitoring/graphite.pp 
b/modules/eventlogging/manifests/monitoring/graphite.pp
index e7553be..a10606a 100644
--- a/modules/eventlogging/manifests/monitoring/graphite.pp
+++ b/modules/eventlogging/manifests/monitoring/graphite.pp
@@ -64,7 +64,7 @@
     # kafka pipeline
     monitoring::graphite_threshold { 'eventlogging_overall_inserted_rate':
         description   => 'Overall insertion rate from MySQL consumer',
-        metric        => "eventlogging.overall.inserted.rate",
+        metric        => 'eventlogging.overall.inserted.rate',
         warning       => 100,
         critical      => 10,
         percentage    => 20, # At least 3 of the (25 - 10) = 15 readings
diff --git a/modules/varnish/manifests/instance.pp 
b/modules/varnish/manifests/instance.pp
index fa73ae2..b88f7d2 100644
--- a/modules/varnish/manifests/instance.pp
+++ b/modules/varnish/manifests/instance.pp
@@ -49,7 +49,7 @@
     }
 
     # lint:ignore:quoted_booleans
-    if inline_template("<%= @directors.map{|k,v| v['dynamic'] 
}.include?('yes') %>") == "true" {
+    if inline_template("<%= @directors.map{|k,v| v['dynamic'] 
}.include?('yes') %>") == 'true' {
         $use_dynamic_directors = true
     } else {
         $use_dynamic_directors = false

-- 
To view, visit https://gerrit.wikimedia.org/r/256472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic834d12574d5d5eb04c9701c83c8250451f7d693
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits