Sumit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/256664

Change subject: Convert title to its language variant
......................................................................

Convert title to its language variant

The title rendered on the banner is first converted to its Language variant
using LanguageConverter::convertTitle().

Bug: T114734
Change-Id: I77e135386eb863ff594fdc9573ee21859ef5d3d6
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/64/256664/1

diff --git a/includes/WikidataPageBanner.hooks.php 
b/includes/WikidataPageBanner.hooks.php
index 572144d..7b5144d 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -242,8 +242,11 @@
                        self::addBadParserFunctionArgsWarning( 
$argumentsFromParserFunction, $parser );
 
                        // set title and tooltip attribute to default title
-                       $paramsForBannerTemplate['tooltip'] = $title->getText();
-                       $paramsForBannerTemplate['title'] = $title->getText();
+                       // convert title to language variant as done in core 
Parser.php
+                       $paramsForBannerTemplate['tooltip'] = 
$parser->getConverterLanguage()
+                               ->convertTitle( $title );
+                       $paramsForBannerTemplate['title'] = 
$parser->getConverterLanguage()
+                               ->convertTitle( $title );
                        if ( isset( $argumentsFromParserFunction['pgname'] ) ) {
                                // set tooltip attribute to  parameter 
'pgname', if set
                                $paramsForBannerTemplate['tooltip'] = 
$argumentsFromParserFunction['pgname'];

-- 
To view, visit https://gerrit.wikimedia.org/r/256664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77e135386eb863ff594fdc9573ee21859ef5d3d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to