Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/256679
Change subject: Remove brackets from require_once
......................................................................
Remove brackets from require_once
This is a detail the MediaWiki style guide dictytes. This is not a
function but a language construct. E.g. you would not write
return( 'string' ).
Change-Id: I4c3ad177199abefc4b57d5ee4af8240ea59dd14f
---
M maintenance/deleteEducation.php
M maintenance/fixInvalidStudent.php
M maintenance/fixSummaryData.php
M maintenance/importWEPData.php
M maintenance/importWEPFromDB.php
5 files changed, 7 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram
refs/changes/79/256679/1
diff --git a/maintenance/deleteEducation.php b/maintenance/deleteEducation.php
index 6aaaada..10fa867 100644
--- a/maintenance/deleteEducation.php
+++ b/maintenance/deleteEducation.php
@@ -60,4 +60,4 @@
}
$maintClass = 'DeleteEducation';
-require_once( RUN_MAINTENANCE_IF_MAIN );
+require_once RUN_MAINTENANCE_IF_MAIN;
diff --git a/maintenance/fixInvalidStudent.php
b/maintenance/fixInvalidStudent.php
index fd1c382..d491390 100644
--- a/maintenance/fixInvalidStudent.php
+++ b/maintenance/fixInvalidStudent.php
@@ -110,4 +110,5 @@
}
}
-$maintClass = '\EducationProgram\FixInvalidStudent'; require_once(
RUN_MAINTENANCE_IF_MAIN );
+$maintClass = '\EducationProgram\FixInvalidStudent';
+require_once RUN_MAINTENANCE_IF_MAIN;
diff --git a/maintenance/fixSummaryData.php b/maintenance/fixSummaryData.php
index 16f769d..0b7e2e4 100644
--- a/maintenance/fixSummaryData.php
+++ b/maintenance/fixSummaryData.php
@@ -43,4 +43,5 @@
}
}
-$maintClass = '\EducationProgram\FixSummaryData'; require_once(
RUN_MAINTENANCE_IF_MAIN );
+$maintClass = '\EducationProgram\FixSummaryData';
+require_once RUN_MAINTENANCE_IF_MAIN;
diff --git a/maintenance/importWEPData.php b/maintenance/importWEPData.php
index 69435af..3b5f208 100644
--- a/maintenance/importWEPData.php
+++ b/maintenance/importWEPData.php
@@ -243,4 +243,4 @@
}
$maintClass = 'EducationProgram\ImportWEPData';
-require_once( RUN_MAINTENANCE_IF_MAIN );
+require_once RUN_MAINTENANCE_IF_MAIN;
diff --git a/maintenance/importWEPFromDB.php b/maintenance/importWEPFromDB.php
index 5111f03..6957b90 100644
--- a/maintenance/importWEPFromDB.php
+++ b/maintenance/importWEPFromDB.php
@@ -347,4 +347,4 @@
}
$maintClass = 'EducationProgram\ImportWEPFromDB';
-require_once( RUN_MAINTENANCE_IF_MAIN );
+require_once RUN_MAINTENANCE_IF_MAIN;
--
To view, visit https://gerrit.wikimedia.org/r/256679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c3ad177199abefc4b57d5ee4af8240ea59dd14f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
