OliverKeyes has submitted this change and it was merged.
Change subject: Fix to exclude A/B test events.
......................................................................
Fix to exclude A/B test events.
Apparently our A/B test implementation does not use NULL for
"not in the test" but the literal string null ;p. Whoops.
Change-Id: I621d8d2135e20b5e7267b60187f4c5b3274235f7
---
M portal/portal.R
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
OliverKeyes: Verified; Looks good to me, approved
diff --git a/portal/portal.R b/portal/portal.R
index f9bea5e..e6687bb 100644
--- a/portal/portal.R
+++ b/portal/portal.R
@@ -7,10 +7,11 @@
event_session_id AS session,
event_destination AS destination,
event_event_type AS type,
- event_section_used AS section_used",
+ event_section_used AS section_used,
+ event_cohort",
date = date,
table = table,
- conditionals = "event_cohort IS NULL")
+ conditionals = "((event_cohort IS NULL) OR (event_cohort
= 'null'))")
# Sanitise
data$section_used[is.na(data$section_used)] <- "no action"
--
To view, visit https://gerrit.wikimedia.org/r/257512
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I621d8d2135e20b5e7267b60187f4c5b3274235f7
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: OliverKeyes <oke...@wikimedia.org>
Gerrit-Reviewer: OliverKeyes <oke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
