jenkins-bot has submitted this change and it was merged.
Change subject: Fix some old code leftovers
......................................................................
Fix some old code leftovers
This class was refactored in Ideaba2a1431c4dca10e8706536db30f410930ed0
but some minor bits and pieces were left behind.
They're not breaking anything, though. This is just some small cleanup.
Change-Id: I00f12c028a75125db968f8676c745db12a87d27e
---
M includes/Data/Index/PostRevisionTopicHistoryIndex.php
M includes/Data/Storage/PostRevisionTopicHistoryStorage.php
2 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Sbisson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Data/Index/PostRevisionTopicHistoryIndex.php
b/includes/Data/Index/PostRevisionTopicHistoryIndex.php
index 301777b..c7e7ab1 100644
--- a/includes/Data/Index/PostRevisionTopicHistoryIndex.php
+++ b/includes/Data/Index/PostRevisionTopicHistoryIndex.php
@@ -24,42 +24,42 @@
}
/**
- * @param PostRevision|PostSummary $object
+ * @param PostRevision $object
* @param array $row
*/
public function cachePurge( $object, array $row ) {
- $row['topic_root_id'] = $this->findTopicId( $object, array() );
+ $row['topic_root_id'] = $this->findTopicId( $object );
parent::cachePurge( $object, $row );
}
/**
- * @param PostRevision|PostSummary $object
+ * @param PostRevision $object
* @param string[] $new
* @param array $metadata
*/
public function onAfterInsert( $object, array $new, array $metadata ) {
- $new['topic_root_id'] = $this->findTopicId( $object, $metadata
);
+ $new['topic_root_id'] = $this->findTopicId( $object );
parent::onAfterInsert( $object, $new, $metadata );
}
/**
- * @param PostRevision|PostSummary $object
+ * @param PostRevision $object
* @param string[] $old
* @param string[] $new
* @param array $metadata
*/
public function onAfterUpdate( $object, array $old, array $new, array
$metadata ) {
- $old['topic_root_id'] = $new['topic_root_id'] =
$this->findTopicId( $object, $metadata );
+ $old['topic_root_id'] = $new['topic_root_id'] =
$this->findTopicId( $object );
parent::onAfterUpdate( $object, $old, $new, $metadata );
}
/**
- * @param PostRevision|PostSummary $object
+ * @param PostRevision $object
* @param string[] $old
* @param array $metadata
*/
public function onAfterRemove( $object, array $old, array $metadata ) {
- $old['topic_root_id'] = $this->findTopicId( $object, $metadata
);
+ $old['topic_root_id'] = $this->findTopicId( $object );
parent::onAfterRemove( $object, $old, $metadata );
}
@@ -67,7 +67,7 @@
* Finds topic ID for given Post
*
* @param PostRevision $post
- * return UUID Topic ID
+ * @return UUID Topic ID
*/
protected function findTopicId( PostRevision $post ) {
return $post->getRootPost()->getPostId();
diff --git a/includes/Data/Storage/PostRevisionTopicHistoryStorage.php
b/includes/Data/Storage/PostRevisionTopicHistoryStorage.php
index d1ffb0a..ec2da39 100644
--- a/includes/Data/Storage/PostRevisionTopicHistoryStorage.php
+++ b/includes/Data/Storage/PostRevisionTopicHistoryStorage.php
@@ -8,7 +8,7 @@
use Flow\Repository\TreeRepository;
/**
- * Query-only storage implementation providess history of all post revisions
in a topic.
+ * Query-only storage implementation provides history of all post revisions in
a topic.
*/
class PostRevisionTopicHistoryStorage implements ObjectStorage {
--
To view, visit https://gerrit.wikimedia.org/r/243497
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00f12c028a75125db968f8676c745db12a87d27e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
